Skip to content

Modifying debugger to return the same breakpoints in 'debugInfo' response as 'setBreakpoints' #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 2 commits into from
Aug 4, 2023
Merged

Modifying debugger to return the same breakpoints in 'debugInfo' response as 'setBreakpoints' #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f7717
modifying setBreakpoints handler to record setBreakpoints response fo…
vaishnavi17 Aug 4, 2023
e631535
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ipykernel/debugger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,15 @@ async def setBreakpoints(self, message):
"""Handle a set breakpoints message."""
source = message["arguments"]["source"]["path"]
self.breakpoint_list[source] = message["arguments"]["breakpoints"]
return await self._forward_message(message)
message_response = await self._forward_message(message)
# debugpy can set breakpoints on different lines than the ones requested,
# so we want to record the breakpoints that were actually added
if "success" in message_response and message_response["success"]:
self.breakpoint_list[source] = [
{"line": breakpoint["line"]}
for breakpoint in message_response["body"]["breakpoints"]
]
return message_response

async def source(self, message):
"""Handle a source message."""
Expand Down