Skip to content

More Informative assert #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianthomas23 merged 2 commits into from
Feb 3, 2025
Merged

More Informative assert #1314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce1157
More Informative assert
Carreau Jan 21, 2025
21d64f8
mark xfail
Carreau Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_subshells.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ def test_thread_ids():
delete_subshell_helper(kc, subshell_id)


@pytest.mark.xfail(
strict=False, reason="this randomly fail and make downstream testing less useful"
)
@pytest.mark.parametrize("are_subshells", [(False, True), (True, False), (True, True)])
@pytest.mark.parametrize("overlap", [True, False])
def test_run_concurrently_sequence(are_subshells, overlap):
Expand Down Expand Up @@ -166,7 +169,7 @@ def test_run_concurrently_sequence(are_subshells, overlap):
delete_subshell_helper(kc, subshell_id)

for reply in replies:
assert reply["content"]["status"] == "ok"
assert reply["content"]["status"] == "ok", reply


@pytest.mark.parametrize("include_main_shell", [True, False])
Expand Down
Loading