handle datetime in json_clean #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime objects are allowed, and serialized to ISO8601
Member
|
Looks good. |
Member
|
By the way, IIRC, there is a difference between how python and how browsers handle local vs. UTC. If I remember correctly, we were having issues where python converted things to UTC, and the browser assumed it was local time, or vice versa, if the timezone offset wasn't explicitly specified. There's a whole can of worms there. |
Member
|
I love time zones. |
Member
|
Looking at the contents service code, I think we're leaving it up to code that creates datetimes to ensure they're 'timezone aware', and then |
GRcharles
added a commit
to GRcharles/ipykernel
that referenced
this pull request
Dec 14, 2022
format dates as ISO8601 - currently works for datetimes, but not dates. Follow up to ipython#18
blink1073
pushed a commit
that referenced
this pull request
Dec 14, 2022
* format dates as ISO8601 format dates as ISO8601 - currently works for datetimes, but not dates. Follow up to #18 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update test_jsonutil.py * Update jsonutil.py * Update test_jsonutil.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update test_jsonutil.py * fix date test Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime objects are allowed, and serialized to ISO8601
closes jupyter-widgets/ipywidgets#35