Some removal of ipython_genutils.py3compat. #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
commented
Mar 8, 2021
| for key, encoded in encoded.items(): | ||
| b64_str[key] = unicode_to_str(encoded) | ||
| encoded3 = json_clean(encode_images(b64_str)) | ||
| assert encoded3 == b64_str |
Member
Author
There was a problem hiding this comment.
unicode to str is no-op, and then this code becomes strictly identical to the one with encoded2.
Carreau
force-pushed
the
remove-genutils
branch
2 times, most recently
from
994e052 to
756f504
Compare
As in some of the other Jupyter Repositories; this start to remove ipython_genutils because of packaging problem in linux distribution (getting rid of nose). This is a step toward that. Note that this changes is slightly stricter in some area where function would previously accept string/bytes and now only accept one; but as far as I can tell are generally only used with one of those since we are Python 3 only.
Member
|
@Carreau are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in some of the other Jupyter Repositories; this start to remove
ipython_genutils because of packaging problem in linux distribution
(getting rid of nose).
This is a step toward that.
Note that this changes is slightly stricter in some area where function
would previously accept string/bytes and now only accept one; but as far
as I can tell are generally only used with one of those since we are
Python 3 only.