Skip to content

Import configure_inline_support from matplotlib_inline if available #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 2 commits into from
May 5, 2021
Merged

Import configure_inline_support from matplotlib_inline if available #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0f7e3
Import configure_inline_support from matplotlib_inline if available
ccordoba12 May 5, 2021
f62c76a
Install stable version of jupyter_client in CIs
ccordoba12 May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
- name: Install the Python dependencies
run: |
pip install --pre --upgrade --upgrade-strategy=eager .[test] codecov
pip install jupyter_client==6.1.*
- name: Install matplotlib
if: ${{ matrix.os != 'macos' && matrix.python-version != 'pypy3' }}
run: |
Expand Down
5 changes: 4 additions & 1 deletion ipykernel/zmqshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,10 @@ def init_magics(self):
def enable_matplotlib(self, gui=None):
gui, backend = super(ZMQInteractiveShell, self).enable_matplotlib(gui)

from ipykernel.pylab.backend_inline import configure_inline_support
try:
from matplotlib_inline.backend_inline import configure_inline_support
except ImportError:
from ipykernel.pylab.backend_inline import configure_inline_support

configure_inline_support(self, backend)

Expand Down