Skip to content

only store the parent header in parent_headers #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minrk wants to merge 1 commit into from
Closed

only store the parent header in parent_headers #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipykernel/inprocess/ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def _input_request(self, prompt, ident, parent, password=False):
content = json_clean(dict(prompt=prompt, password=password))
msg = self.session.msg('input_request', content, parent)
for frontend in self.frontends:
if frontend.session.session == parent['header']['session']:
if frontend.session.session == parent['session']:
frontend.stdin_channel.call_handlers(msg)
break
else:
Expand Down
6 changes: 5 additions & 1 deletion ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ def _parent_header(self):
DeprecationWarning,
stacklevel=2,
)
return self.get_parent_header(channel="shell")
# _parent_header wasn't actually the header, it was the *message*
# but only promised access to the header
return {"header": self.get_parent_header(channel="shell")}

# Time to sleep after flushing the stdout/err buffers in each execute
# cycle. While this introduces a hard limit on the minimal latency of the
Expand Down Expand Up @@ -538,6 +540,8 @@ def set_parent(self, ident, parent, channel='shell'):
on the stdin channel.
"""
self._parent_ident[channel] = ident
if parent and 'header' in parent:
parent = parent['header']
self._parent_headers[channel] = parent

def send_response(self, stream, msg_or_type, content=None, ident=None,
Expand Down