Skip to content

Remove deprecated source parameter since 4.0.1 (2015) #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Jun 15, 2021
Merged

Remove deprecated source parameter since 4.0.1 (2015) #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions ipykernel/zmqshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@
# Functions and classes
#-----------------------------------------------------------------------------

_sentinel = object()


class ZMQDisplayPublisher(DisplayPublisher):
"""A display publisher that publishes data using a ZeroMQ PUB socket."""
Expand Down Expand Up @@ -97,7 +95,6 @@ def publish(
self,
data,
metadata=None,
source=_sentinel,
transient=None,
update=False,
):
Expand All @@ -115,23 +112,7 @@ def publish(
Transient data should not be persisted to documents.
update : bool, optional, keyword-only
If True, send an update_display_data message instead of display_data.
source : unused
Value will have no effect on function behavior. Parameter is still
present for backward compatibility but will be removed in the
future.

.. deprecated:: 4.0.1

`source` has been deprecated and no-op since ipykernel 4.0.1
(2015)
"""
if source is not _sentinel:
warnings.warn(
"`source` has been deprecated since ipykernel 4.0.1 "
"and will have no effect",
DeprecationWarning,
stacklevel=2,
)
self._flush_streams()
if metadata is None:
metadata = {}
Expand Down