Skip to content

Conversation

@carlosperate
Copy link

#759

This was an implicit dependency via Traitlets, but it was removed in version 5.1 and needs to be explicitly included now.

@blink1073
Copy link
Contributor

Looks like we need to add it to build reqs as well:

"setuptools",

@blink1073 blink1073 added this to the 5.5 milestone Oct 6, 2021
@carlosperate
Copy link
Author

I'll try that, but I think I might need to move from ipython_genutils.path import filefind in ipykernel/connect.py (which is imported at the time the wheel is built via __init__.py) as done here: 10044cc

@carlosperate
Copy link
Author

Oh wait, I didn't realised that was a pyproject.toml file, you are probably right and that could be enough!

This was an implicit dependency via Traitlets, but it was removed
in version 5.1 and needs to be explicitly included now.

#759
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit d355b3c into ipython:5.5.x Oct 6, 2021
@carlosperate
Copy link
Author

Awesome, thanks @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants