Unpin IPython, and remove some dependencies on it. #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it annoying to test whether IPython breaks IPykernel. I'm almost always on IPython master branch and I'd like to know when/if I break things. Prompted by ipython/ipython#13252, which is not breaking ipykernel, but it's better to decouple where we can.
Contributor
|
We had added the pin as a failsafe in case there are breaking API changes, I'd feel better about removing it if |
Member
Author
|
Thanks for the pointer, the pyargs and --upgrade-strategy=only-if-needed are useful. Should I test both master an released or just released ? |
Contributor
|
I'd say just master, since then we can update ipykernel prior to the release to be compatible. |
Member
Author
|
I just merged ipython/ipython#13266 that test upstream master. |
Contributor
|
Nice, thanks! |
blink1073
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it annoying to test whether IPython breaks IPykernel.
I'm almost always on IPython master branch and I'd like to know when/if
I break things.
Prompted by ipython/ipython#13252,
which is not breaking ipykernel, but it's better to decouple where we
can.