Skip to content

Conversation

@dlukes
Copy link
Contributor

@dlukes dlukes commented Nov 22, 2021

This should help get rid of chatty EncodingWarnings for users on 3.10 with PYTHONWARNDEFAULTENCODING enabled (such as myself) :)

@dlukes dlukes changed the title Add explicit encoding to open calls Add explicit encoding to open calls in debugger Nov 22, 2021
@blink1073 blink1073 added this to the 6.5 milestone Nov 23, 2021
@blink1073
Copy link
Contributor

cc @minrk, it looks like adding encoding affects ipyparallel.

@blink1073
Copy link
Contributor

Thanks for the contribution @dlukes!

@minrk minrk merged commit 54fea2a into ipython:master Nov 23, 2021
@minrk
Copy link
Member

minrk commented Nov 23, 2021

This didn't affect ipyparallel, there just appears to be a flaky test in the latest release.

@dlukes dlukes deleted the patch-1 branch November 23, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants