Clean python 2 artifacts. Fix #826 #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `IOError` is `OSError` in python3 * `io.open` -> `open` * `return str()` -> `return ''` directly * direct `super()` call * do not subclass `object`
davidbrochart
approved these changes
Dec 22, 2021
Collaborator
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
You also made the following changes:
- replace
.format()withf-strings - replace
set([1, 2])with{1, 2}
Co-authored-by: David Brochart <david.brochart@gmail.com>
ipykernel/zmqshell.py
Outdated
| f" $> jupyter <app> --existing {connection_file}\n" | ||
| "or even just:\n" | ||
| " $> jupyter <app> --existing\n" | ||
| "if this is the most recent Jupyter kernel you have started.".format( |
Collaborator
There was a problem hiding this comment.
You also need to remove .format(connection_file).
Contributor
Author
There was a problem hiding this comment.
it was removed, like almost all other format calls in next commit
f-strings is faster, than `str().format`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOErrorisOSErrorin python3io.open->openreturn str()->return ''directlysuper()callobject