Skip to content

tornado 4 fixes #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minrk merged 2 commits into from
Jun 28, 2018
Merged

tornado 4 fixes #337

minrk merged 2 commits into from
Jun 28, 2018

Conversation

@minrk
Copy link
Member

@minrk minrk commented Jun 25, 2018

With tornado 4, we were not instantiating the background IOLoop correctly

  • instantiate IOLoop explicitly and call .make_current()
  • pass IOLoop instance to ZMQStream constructors, which refer to IOLoop.instance if unspecified, not IOLoop.current

closes #334

@minrk minrk added this to the 6.2.2 milestone Jun 25, 2018
@minrk
ensure correct ioloop is used on tornado 4
f19af46 
default of ZMQStream is to use IOLoop.instance, which isn't correct in a background thread on tornado < 5
@minrk minrk mentioned this pull request Jun 25, 2018
Closed
@minrk minrk merged commit ce5f0b8 into ipython:master Jun 28, 2018
@minrk minrk deleted the t4 branch June 28, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.2.2

Development

Successfully merging this pull request may close these issues.

ipyparallel broken for tornado 4.5.3 ("RuntimeError: IOLoop is already running")

1 participant

@minrk