Skip to content

Conversation

@flyinghuman
Copy link

this fixes the error during index update if there are no adresses.

@TheHolyRoger
Copy link
Collaborator

@flyinghuman why aren't there any addresses?

Looks like an easy merge but wondering what the cause is, not seen this.

@uaktags have you?

@TheHolyRoger
Copy link
Collaborator

@TheHolyRoger
Copy link
Collaborator

This has been hanging around since #56

I'm just not sure if the fix in this PR is good enough or we need to handle it better?

@uaktags
Copy link
Collaborator

uaktags commented Jan 24, 2020

It's an easy fix indeed, but the problems seem to be related to coin specific anomalies. It may be more suited to later look into coin-specific parsing objects that we call during these checks. Basically we do checks against what the coin allows, and either skip over all of it to do a save_tx without vins/vouts or proceed with them. Not exactly sure how to do that cleanly though as already just typing it out sounds pretty stupid and intensive of a process for the sync.

@TheHolyRoger TheHolyRoger added this to the Coin-Commands milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants