[irods/irods#7726,irods/irods#8330,irods/irods#8332] Migrate to system CMake, nlohmann-json, and spdlog (main)#236
Merged
alanking merged 3 commits intoirods:mainfrom May 7, 2025
Conversation
SwooshyCueb
changed the title
Member
Author
|
Ready for review |
korydraughn
reviewed
May 2, 2025
Contributor
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Looks good.
Awaiting response to review comments for the storage tiering plugin and indexing plugin.
Forgot to ask, did you see the tests pass for this?
Member
Author
|
I'm getting four test failures (everything else passes) on Ubuntu 24.04 with Postgres 16. They don't appear related to my changes. |
Contributor
|
Ok. Put those test failures in issues. We'll handle them in separate PRs. |
korydraughn
approved these changes
May 6, 2025
Contributor
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Pound it once the issues are created.
This was referenced May 6, 2025
Member
Author
|
#'d |
alanking
approved these changes
May 6, 2025
Contributor
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Will merge along with irods/irods#8366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In service of irods/irods#7726
In service of irods/irods#8330
In service of irods/irods#8332