Skip to content

Add support for UUID-specific iPXE scripts via /ipxe/<uuid>#165

Merged
defo89 merged 4 commits intomainfrom
ipxe-support-uuid
Apr 7, 2025
Merged

Add support for UUID-specific iPXE scripts via /ipxe/<uuid>#165
defo89 merged 4 commits intomainfrom
ipxe-support-uuid

Conversation

@defo89
Copy link
Copy Markdown
Contributor

@defo89 defo89 commented Mar 26, 2025

Proposed Changes

  • return specific ipxe script if /ipxe/<uuid> is called and matching ipxeBootConfigList is found
  • remove default ipxe script and related params

Fixes #159

@defo89 defo89 added the enhancement New feature or request label Mar 26, 2025
@defo89 defo89 requested a review from a team as a code owner March 26, 2025 15:56
@defo89 defo89 marked this pull request as draft March 26, 2025 15:56
Comment thread server/bootserver.go Outdated
@defo89 defo89 force-pushed the ipxe-support-uuid branch 2 times, most recently from 6dc456c to f5babf0 Compare March 27, 2025 21:25
@defo89 defo89 force-pushed the ipxe-support-uuid branch from f5babf0 to 0b51cf7 Compare March 27, 2025 21:26
@defo89 defo89 marked this pull request as ready for review April 1, 2025 16:25
Copy link
Copy Markdown
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @defo89, left few comments inline.

Comment thread server/bootserver.go Outdated
Comment thread server/bootserver.go Outdated
Comment thread server/bootserver.go Outdated
@hardikdr hardikdr changed the title bootserver: Add /ipxe/uuid enpoint Add support for UUID-specific iPXE scripts via /ipxe/<uuid> Apr 2, 2025
@hardikdr hardikdr moved this from Backlog to In progress in Metal Automation Apr 2, 2025
@hardikdr hardikdr added this to the H1/2025 milestone Apr 2, 2025
hardikdr
hardikdr previously approved these changes Apr 4, 2025
Copy link
Copy Markdown
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor logging suggestion inline.
Looks good, thanks again!!

Comment thread server/bootserver.go Outdated
Co-authored-by:  Hardik Dodiya <hardik.dodiya@sap.com>
@defo89 defo89 enabled auto-merge (squash) April 7, 2025 08:59
@defo89 defo89 merged commit a823d0a into main Apr 7, 2025
7 checks passed
@defo89 defo89 deleted the ipxe-support-uuid branch April 7, 2025 09:09
@github-project-automation github-project-automation Bot moved this from In progress to Done in Metal Automation Apr 7, 2025
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

Do not rely on SystemIP to serve IPXE

3 participants