Conversation
github-actions
Bot
added
the
documentation
hardikdr
reviewed
Apr 7, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
Left minor comments, looks really good overall, thanks for the PR @SzymonSAP
hardikdr
approved these changes
Apr 10, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
Thanks for the changes. Let's wait for today if anyone else is willing to take a peek before we merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
bootctlcommandbootctl movecommand to move all boot CRs with theirs secrets and set theirs owners in a target clusterFixes #98