Drop kube-rbac-proxy container config for metrics#177
Conversation
hardikdr
left a comment
There was a problem hiding this comment.
@Rohit-0505 Thanks for the PR!
I see there are significant changes — have you been able to test them end-to-end?
Also, are these changes aligned with any other project within ironcore-dev (e.g., metal-operator)? If so, could you please link the related PR here?
To perform the e2e-test, I have followed the kubebuilder approach for testing the metrics endpoint validation, and a github workflow is also added in this PR for e2e-test |
hardikdr
left a comment
There was a problem hiding this comment.
Thanks @Rohit-0505, the workflow is helpful.
hardikdr
left a comment
There was a problem hiding this comment.
Can you please resolve the conflicts with the main branch, and we are good to go then.
fb93bb5 to
c06b60a
Compare
c06b60a to
68e2e1a
Compare
PR is rebased and resolved all conflicts. |
The PR removes the soon-to-be deprecated
kube-rbac-proxycontainer dependency and replaces it withController-Runtime'sbuilt-in authn/authz for securing the metrics endpoint. This simplifies setup, enhances security, and follows the latest Kubebuilder best practices.Key Changes
kube-rbac-proxydependency.Fixes #108
Ref for reviewer (The link below has the discussions and steps to be follwed)
kubernetes-sigs/kubebuilder#3907