Merged
Conversation
2d9c4fe to
16dfad5
Compare
byteocean
approved these changes
Mar 19, 2026
Contributor
byteocean
left a comment
There was a problem hiding this comment.
Thanks for explaining. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #768
In a previous PR #714 I changed the behavior of MAC address discovery for the VM.
The idea was to only update the MAC once, so prevent unnecessary memory copy.
I knew that the user can change a MAC manually in the VM, but that was really not a concern.
What I missed though is the fact, that iPXE and systemd both use different MAC address:
MACAddressPolicy=persistentin/usr/lib/systemd/network/99-default.linkit generates a new MACI was able to make this happen on many host machine reboots. After applying this PR I am unable to do it