Remove dependency on kube-rbac-proxy by adopting controller-runtime's native authn/authz for metrics#1226
Merged
afritzler merged 2 commits intoironcore-dev:mainfrom Mar 25, 2025
Conversation
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
from
8ee3622 to
cbe1faa
Compare
…'s native authn/authz for metrics
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
from
cbe1faa to
2e4d763
Compare
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
4 times, most recently
from
aece9f2 to
3e5c218
Compare
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
3 times, most recently
from
5c3d7cf to
752cb0a
Compare
lukas016
force-pushed
the
osc/enh/replace-kube-rbac-proxy
branch
from
752cb0a to
2b5375c
Compare
afritzler
requested changes
Mar 6, 2025
Member
afritzler
left a comment
afritzler
left a comment
There was a problem hiding this comment.
Some minor cleanup left overs. We should use this PR to remove all webhook related configuration (even if commented out) to keep the kustomizations clean.
Contributor
Author
As discussed offline, can we remove all webhook components in a separate PR? This PR is mainly focused on replacing |
afritzler
approved these changes
Mar 25, 2025
balpert89
pushed a commit
that referenced
this pull request
Apr 23, 2025
…'s native authn/authz for metrics (#1226) * Remove dependency on `kube-rbac-proxy` by adopting controller-runtime's native authn/authz for metrics * Enhance `cert-manager` integration for metrics endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the soon-to-be deprecated
kube-rbac-proxydependency and replaces it with Controller-Runtime's built-in authentication and authorization for securing the metrics endpoint. This simplifies setup, enhances security, and follows the latest Kubebuilder best practices.Key Changes
kube-rbac-proxydependency.cert-managerintegration to secure metrics with TLS encryption.Fixes #1203
Ref:
kubernetes-sigs/kubebuilder#3907
kubernetes-sigs/controller-runtime#2407
kubernetes-sigs/kubebuilder#4400
kubernetes-sigs/kubebuilder#4558
kubernetes-sigs/kubebuilder/docs/reference/metrics (v4.5.0)