Skip to content

BCN 04/19 - Gus#8

Open
Gusbe wants to merge 2 commits intoironhackbcn:masterfrom
Gusbe:master
Open

BCN 04/19 - Gus#8
Gusbe wants to merge 2 commits intoironhackbcn:masterfrom
Gusbe:master

Conversation

@Gusbe
Copy link
Copy Markdown

@Gusbe Gusbe commented Apr 4, 2019

No description provided.

Copy link
Copy Markdown
Collaborator

@tawebbcn tawebbcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Comment thread stylesheets/style.css
nav grey: #5b5e6d;
*/

/* ---- reset ---- */
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset at the top, good

Comment thread stylesheets/style.css
flex-direction: column;
}

nav {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This si not reset anymore, maybe you could add a breaking comment to specify that

Comment thread stylesheets/style.css

nav {
display: flex;
flex-direction: row;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default flex-direction is row

Comment thread stylesheets/style.css
#menu {
margin: 10px;
}
.bar-menu {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to be consistent with the format. If you put a blank space between the rules, put it all the time

Comment thread stylesheets/style.css

#links ul {
display: flex;
flex-direction: row;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants