Skip to content

Comments

fix: parsing unhandled exceptions#52

Merged
Alex-GF merged 3 commits intodevelopfrom
fix/pricing-parser
Jul 3, 2025
Merged

fix: parsing unhandled exceptions#52
Alex-GF merged 3 commits intodevelopfrom
fix/pricing-parser

Conversation

@javiercavlop
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/io/github/isagroup/services/parsing/PricingManagerParser.java:362

  • Broadly catching NullPointerException here may obscure underlying issues with missing or malformed add-on data. Consider adding explicit null checks before parsing to better isolate error sources.
} catch (ClassCastException | NullPointerException | IllegalArgumentException e) {

src/main/java/io/github/isagroup/services/parsing/PlanParser.java:199

  • Using a try/catch around planUsageLimitMap.get('value') may mask issues where the map itself is null. It could be clearer to explicitly check for the presence of the key or the map before retrieving its value.
Object value = null;

@javiercavlop javiercavlop requested a review from Alex-GF April 8, 2025 18:50
@Alex-GF Alex-GF merged commit 803915a into develop Jul 3, 2025
1 check passed
@Alex-GF Alex-GF deleted the fix/pricing-parser branch July 3, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants