Skip to content

Fixes terrain_out_of_bounds to return tensor instead of bool #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mayankm96 merged 4 commits into from
Aug 28, 2025
Merged

Fixes terrain_out_of_bounds to return tensor instead of bool #3180

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d968f5b
Fix terrain_out_of_bounds to return tensor instead of bool
fan-ziqi Aug 16, 2025
e89d960
precommit
fan-ziqi Aug 16, 2025
e728bd7
Merge branch 'main' into devel-bool
Mayankm96 Aug 22, 2025
6267372
Merge branch 'main' into devel-bool
Mayankm96 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/isaaclab_tasks/isaaclab_tasks/manager_based/locomotion/velocity/mdp/terminations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ def terrain_out_of_bounds(
to the edge of the terrain is calculated based on the size of the terrain and the distance buffer.
"""
if env.scene.cfg.terrain.terrain_type == "plane":
return False # we have infinite terrain because it is a plane
# we have infinite terrain because it is a plane
return torch.zeros(env.num_envs, dtype=torch.bool, device=env.device)
elif env.scene.cfg.terrain.terrain_type == "generator":
# obtain the size of the sub-terrains
terrain_gen_cfg = env.scene.terrain.cfg.terrain_generator
Expand Down
Loading