Skip to content

Fixes teleop G1 with Inspire hand issues#3440

Merged
kellyguo11 merged 2 commits into
isaac-sim:release/2.3.0from
yami007007:fix-bug-3242-TeleopG1-inspire
Sep 16, 2025
Merged

Fixes teleop G1 with Inspire hand issues#3440
kellyguo11 merged 2 commits into
isaac-sim:release/2.3.0from
yami007007:fix-bug-3242-TeleopG1-inspire

Conversation

@yami007007
Copy link
Copy Markdown
Contributor

Description

Fix: teleop G1 with Inspire hand (PR #3242), modifications includes:

  • Correct the USD asset path of G1_INSPIRE_FTP_CFG
  • Increase arm damping for stability using the new pink_ik wrapper

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

  • Only modified the unitree.py file.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added bug Something isn't working documentation Improvements or additions to documentation asset New asset feature or request isaac-sim Related to Isaac Sim team isaac-mimic Related to Isaac Mimic team infrastructure labels Sep 11, 2025
@yami007007 yami007007 changed the base branch from main to release/2.3.0 September 11, 2025 13:20
@Mayankm96 Mayankm96 removed documentation Improvements or additions to documentation isaac-sim Related to Isaac Sim team isaac-mimic Related to Isaac Mimic team infrastructure labels Sep 11, 2025
@@ -564,7 +564,7 @@
"""

G1_INSPIRE_FTP_CFG = G1_29DOF_CFG.copy()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does FTP stand for?

Copy link
Copy Markdown
Contributor Author

@yami007007 yami007007 Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTP is a product line of Inspire's dexterous hands, which we use in our task (the name "FTP" likely originates from "Force/Torque/Position").

Copy link
Copy Markdown
Collaborator

@ooctipus ooctipus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, :))

It will be nice if you can let user know what is FTP
how is this config differs from the g1_29dof_inspire_hand
and where are the reference of stiffness, damping, effort_limit, velocity limit coming from?
is it test empirically? or is it got from unitree spec? or is it tuned for simulation, this will make everyone who uses this know what is the right expectation when using this articulation.

@kellyguo11 kellyguo11 changed the title Fix: teleop G1 with Inspire hand bug (refs PR #3242) Fixes teleop G1 with Inspire hand issues Sep 15, 2025
@yami007007
Copy link
Copy Markdown
Contributor Author

Thanks for the PR, :))

It will be nice if you can let user know what is FTP how is this config differs from the g1_29dof_inspire_hand and where are the reference of stiffness, damping, effort_limit, velocity limit coming from? is it test empirically? or is it got from unitree spec? or is it tuned for simulation, this will make everyone who uses this know what is the right expectation when using this articulation.

FTP is a product line of Inspire's dexterous hands, which we use in our task (the name "FTP" likely originates from "Force/Torque/Position").
I copied the stiffness, damping, effort_limit, and velocity_limit settings from G1_29DOF_CFG and tuned them for my use case. For example:

  1. The arm's movement was unstable, so I increased the damping for better stability.
  2. The original PD settings for the hand made it too inflexible, so I reduced the parameters to improve flexibility when grasping objects.

@ooctipus
Copy link
Copy Markdown
Collaborator

ooctipus commented Sep 15, 2025

nice!!
then I would say put this in the comment or docstring of this ArticulationCfg that will be very nice!!
you can attach the link to settings from G1_29DOF_CFG, and mention how you tuned to achieve what result

@yami007007
Copy link
Copy Markdown
Contributor Author

nice!! then I would say put this in the comment or docstring of this ArticulationCfg that will be very nice!! you can attach the link to settings from G1_29DOF_CFG, and mention how you tuned to achieve what result

Thanks. Added the comments of how to tune these PD settings for better stability in grasping task.

@kellyguo11 kellyguo11 merged commit f780dad into isaac-sim:release/2.3.0 Sep 16, 2025
4 of 6 checks passed
hougantc-nvda pushed a commit to hougantc-nvda/IsaacLab that referenced this pull request Nov 10, 2025
# Description

Fix: teleop G1 with Inspire hand (PR isaac-sim#3242), modifications includes:
- Correct the USD asset path of G1_INSPIRE_FTP_CFG
- Increase arm damping for stability using the new pink_ik wrapper


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## Screenshots

- Only modified the `unitree.py` file.


## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
hougantc-nvda pushed a commit to hougantc-nvda/IsaacLab that referenced this pull request Nov 10, 2025
# Description

Fix: teleop G1 with Inspire hand (PR isaac-sim#3242), modifications includes:
- Correct the USD asset path of G1_INSPIRE_FTP_CFG
- Increase arm damping for stability using the new pink_ik wrapper


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## Screenshots

- Only modified the `unitree.py` file.


## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asset New asset feature or request bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants