Fixes teleop G1 with Inspire hand issues#3440
Conversation
| @@ -564,7 +564,7 @@ | |||
| """ | |||
|
|
|||
| G1_INSPIRE_FTP_CFG = G1_29DOF_CFG.copy() | |||
There was a problem hiding this comment.
What does FTP stand for?
There was a problem hiding this comment.
FTP is a product line of Inspire's dexterous hands, which we use in our task (the name "FTP" likely originates from "Force/Torque/Position").
There was a problem hiding this comment.
Thanks for the PR, :))
It will be nice if you can let user know what is FTP
how is this config differs from the g1_29dof_inspire_hand
and where are the reference of stiffness, damping, effort_limit, velocity limit coming from?
is it test empirically? or is it got from unitree spec? or is it tuned for simulation, this will make everyone who uses this know what is the right expectation when using this articulation.
FTP is a product line of Inspire's dexterous hands, which we use in our task (the name "FTP" likely originates from "Force/Torque/Position").
|
|
nice!! |
Thanks. Added the comments of how to tune these PD settings for better stability in grasping task. |
# Description Fix: teleop G1 with Inspire hand (PR isaac-sim#3242), modifications includes: - Correct the USD asset path of G1_INSPIRE_FTP_CFG - Increase arm damping for stability using the new pink_ik wrapper ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots - Only modified the `unitree.py` file. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
# Description Fix: teleop G1 with Inspire hand (PR isaac-sim#3242), modifications includes: - Correct the USD asset path of G1_INSPIRE_FTP_CFG - Increase arm damping for stability using the new pink_ik wrapper ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots - Only modified the `unitree.py` file. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Fix: teleop G1 with Inspire hand (PR #3242), modifications includes:
Type of change
Screenshots
unitree.pyfile.Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there