-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Refactors Newton XformPrimView: proper local poses, warp-native API, and shared contract tests #5179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 32 commits into
isaac-sim:develop
from
ooctipus:zhengyuz/xformprim-refactor
Apr 23, 2026
Merged
Refactors Newton XformPrimView: proper local poses, warp-native API, and shared contract tests #5179
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
52bbc99
warp native xform prim view
ooctipus f0c3ca0
update caller to use warp xformprimview
ooctipus 67cb049
improvements
ooctipus f3bbe5b
address concerns
ooctipus 22b38d6
fix linter
ooctipus 4fd67c8
fixes
ooctipus 8bd1f3f
fix the input
ooctipus d0ab973
fix linter
ooctipus 0b660d0
fix raycaster warp conversion
ooctipus 7f99a3d
fix xformprimview callers
ooctipus b80cb71
add nice deprecation messages
ooctipus 215e802
fix remaining issues
ooctipus 8d4078d
fix small bug
ooctipus 7c3e3fa
remove all the "/raycaster" child path
ooctipus e0490f8
fix linter
ooctipus 223285d
more nice fixes
ooctipus e68c5a4
fix linter
ooctipus b461f40
Add docstrings to Newton FrameView kernels and fix camera rebase
AntoineRichard 372c296
Merge branch 'develop' into zhengyuz/xformprim-refactor
kellyguo11 4e90ad9
Apply suggestion from @kellyguo11
kellyguo11 6963b20
Update source/isaaclab_physx/isaaclab_physx/sim/__init__.pyi
kellyguo11 3831133
Merge branch 'develop' into zhengyuz/xformprim-refactor
kellyguo11 ac8f12b
Merge remote-tracking branch 'origin/develop' into zhengyuz/xformprim…
AntoineRichard b7d1bdd
Fix CI test failures in XformPrimView refactor PR
AntoineRichard 709ba25
Add missing prims property to NewtonSiteFrameView
AntoineRichard 09a9997
Fix Camera env_ids type handling for FrameView warp conversion
AntoineRichard cb1cc96
Merge remote-tracking branch 'origin/develop' into zhengyuz/xformprim…
AntoineRichard 6e4ef8b
Merge remote-tracking branch 'origin/develop' into zhengyuz/xformprim…
AntoineRichard ee3d9fd
Fix malformed RST table and add migration guide for FrameView rename
AntoineRichard 7121eb2
Merge remote-tracking branch 'origin/develop' into zhengyuz/xformprim…
AntoineRichard badeb8e
Merge branch 'develop' into zhengyuz/xformprim-refactor
kellyguo11 20632e5
Merge branch 'develop' into zhengyuz/xformprim-refactor
kellyguo11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make sure to document this in the migration guide