Revert "Add NVTX instrumentation to Newton Warp Renderer (#5294)"#5348
Conversation
)" This reverts commit 2287151.
Greptile SummaryThis PR reverts #5294, which added optional NVTX profiling instrumentation to the Confidence Score: 5/5Safe to merge — clean revert with no residual references or side effects. The change is a mechanical revert of a single file, removing optional profiling instrumentation. The resulting file has no dangling imports, no leftover decorator calls, and no logic changes. No P0/P1 issues found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[update_transforms] --> D[SimulationContext.update_scene_data_provider]
B[render] --> E[newton_sensor.update]
C[read_output] --> F[wp.copy to camera_data.output]
style A fill:#4a90d9,color:#fff
style B fill:#27ae60,color:#fff
style C fill:#e67e22,color:#fff
Reviews (1): Last reviewed commit: "Revert "Add NVTX instrumentation to Newt..." | Re-trigger Greptile |
Resolves conflict in source/isaaclab/isaaclab/sensors/camera/camera.py: - Adopt upstream's `FrameView` import (XformPrimView -> FrameView rename from isaac-sim#5179). - Drop `has_kit` import: this branch removed the only `has_kit()` use (the `if not has_kit(): return` early-out in Camera.__init__) when moving Kit/RTX gating into IsaacRtxRenderer (per camera_init_cleanup). Auto-merged camera_cfg.py (XformPrimView -> FrameView in docstring) and newton_warp_renderer.py (NVTX revert from isaac-sim#5348) cleanly. Made-with: Cursor
)" (isaac-sim#5348) We don't need custom instrumentation. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (existing functionality will not work without user modification) - Documentation update ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
We don't need custom instrumentation.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there