-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Newton] Bump Newton pin to v1.2.0rc2 #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c4c2f3d
c03dc52
49872a5
5e16347
f9930a9
6d41e08
f8ab14e
100b399
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Bumped Newton pin to ``v1.2.0rc2``. Pulls in IsaacLab-relevant fixes from | ||
| `newton-physics/newton#2678 <https://github.com/newton-physics/newton/pull/2678>`_ | ||
| and `newton-physics/newton#2720 | ||
| <https://github.com/newton-physics/newton/pull/2720>`_ (``SolverKamino`` | ||
| reset under ``world_mask``), the upstream tendon-scoping fix from | ||
| `newton-physics/newton#2659 | ||
| <https://github.com/newton-physics/newton/pull/2659>`_ ("Scope USD | ||
| custom-frequency parsing"), and a VRAM-leak fix on example reset | ||
| (`newton-physics/newton#2710 | ||
| <https://github.com/newton-physics/newton/pull/2710>`_). | ||
| * Newton ``v1.2.0rc2`` requires ``warp-lang==1.13.0``, ``mujoco==3.8.0``, | ||
| and ``mujoco-warp==3.8.0.1``. ``warp-lang``/``mujoco``/``mujoco-warp`` | ||
| pins live in :mod:`isaaclab` and ``tools/wheel_builder/res/python_packages.toml``; | ||
| the Newton pin is mirrored across :mod:`isaaclab_newton`, | ||
| :mod:`isaaclab_visualizers` (3×), :mod:`isaaclab_physx` (``[newton]`` | ||
| extra), and the wheel-builder TOML. | ||
| * Updated ``wp.math.transform_to_matrix`` to ``wp.transform_to_matrix`` in | ||
| :mod:`~isaaclab_newton.physics.newton_manager` and | ||
| :mod:`~isaaclab_ov.renderers.ovrtx_renderer_kernels` to match the | ||
| ``warp-lang`` 1.13 API (the ``wp.math`` namespace was removed). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added a temporary ``warp.torch`` compatibility shim at | ||
| :mod:`isaaclab_mimic` import time so that cuRobo (NVlabs/curobo) keeps | ||
| working with ``warp-lang>=1.13``, which dropped the ``warp.torch`` | ||
| submodule in favour of top-level ``warp.*`` (e.g. | ||
| ``wp.torch.device_from_torch`` → ``wp.device_from_torch``). cuRobo's | ||
| pinned commit and ``main`` still call ``wp.torch.*`` and raise | ||
| ``AttributeError: module 'warp' has no attribute 'torch'`` at | ||
| :meth:`MotionGenConfig.load_from_robot_config` time. The shim | ||
| reconstructs ``warp.torch`` as a thin forwarding module and is a | ||
| no-op once warp re-introduces the namespace or cuRobo migrates. | ||
| Remove this shim once the cuRobo pin in ``docker/Dockerfile.curobo`` | ||
| is bumped to a commit that uses the top-level ``wp.*`` API directly. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Bumped Newton pin to ``v1.2.0rc2``. Pulls in IsaacLab-relevant fixes from | ||
| `newton-physics/newton#2678 <https://github.com/newton-physics/newton/pull/2678>`_ | ||
| and `newton-physics/newton#2720 | ||
| <https://github.com/newton-physics/newton/pull/2720>`_ (``SolverKamino`` | ||
| reset under ``world_mask``), the upstream tendon-scoping fix from | ||
| `newton-physics/newton#2659 | ||
| <https://github.com/newton-physics/newton/pull/2659>`_ ("Scope USD | ||
| custom-frequency parsing"), and a VRAM-leak fix on example reset | ||
| (`newton-physics/newton#2710 | ||
| <https://github.com/newton-physics/newton/pull/2710>`_). | ||
| * Newton ``v1.2.0rc2`` requires ``warp-lang==1.13.0``, ``mujoco==3.8.0``, | ||
| and ``mujoco-warp==3.8.0.1``. ``warp-lang``/``mujoco``/``mujoco-warp`` | ||
| pins live in :mod:`isaaclab` and ``tools/wheel_builder/res/python_packages.toml``; | ||
| the Newton pin is mirrored across :mod:`isaaclab_newton`, | ||
| :mod:`isaaclab_visualizers` (3×), :mod:`isaaclab_physx` (``[newton]`` | ||
| extra), and the wheel-builder TOML. | ||
| * Updated ``wp.math.transform_to_matrix`` to ``wp.transform_to_matrix`` in | ||
| :mod:`~isaaclab_newton.physics.newton_manager` and | ||
| :mod:`~isaaclab_ov.renderers.ovrtx_renderer_kernels` to match the | ||
| ``warp-lang`` 1.13 API (the ``wp.math`` namespace was removed). | ||
| * Adapted :class:`~isaaclab_newton.renderers.NewtonWarpRenderer` to | ||
| Newton ``v1.2.0rc2``'s explicit shape-BVH lifecycle. | ||
| :meth:`~newton.sensors.SensorTiledCamera.update` no longer auto-builds | ||
| the BVH when a non-``None`` state is passed and the underlying | ||
| ``RenderContext.render`` now raises ``RuntimeError("build_bvh_shape() | ||
| must be called before rendering shapes.")`` if it was never built. The | ||
| renderer now calls ``newton.geometry.build_bvh_shape`` once after | ||
| sensor construction and ``newton.geometry.refit_bvh_shape`` each frame | ||
| before :meth:`~newton.sensors.SensorTiledCamera.update`, since env | ||
| body poses move every step. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,10 +38,10 @@ def run(self): | |
| EXTRAS_REQUIRE = { | ||
| "all": [ | ||
| "prettytable==3.3.0", | ||
| "mujoco==3.6.0", | ||
| "mujoco-warp==3.6.0", | ||
| "mujoco==3.8.0", | ||
| "mujoco-warp==3.8.0.1", | ||
| "PyOpenGL-accelerate==3.1.10", | ||
| "newton @ git+https://github.com/newton-physics/newton.git@a27277ed49d6f307b8a1e4c394be7e1d14965a62", | ||
| "newton @ git+https://github.com/newton-physics/newton.git@v1.2.0rc2", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The previous pin used commit hash |
||
| ], | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Bumped Newton pin to ``v1.2.0rc2``. Pulls in IsaacLab-relevant fixes from | ||
| `newton-physics/newton#2678 <https://github.com/newton-physics/newton/pull/2678>`_ | ||
| and `newton-physics/newton#2720 | ||
| <https://github.com/newton-physics/newton/pull/2720>`_ (``SolverKamino`` | ||
| reset under ``world_mask``), the upstream tendon-scoping fix from | ||
| `newton-physics/newton#2659 | ||
| <https://github.com/newton-physics/newton/pull/2659>`_ ("Scope USD | ||
| custom-frequency parsing"), and a VRAM-leak fix on example reset | ||
| (`newton-physics/newton#2710 | ||
| <https://github.com/newton-physics/newton/pull/2710>`_). | ||
| * Newton ``v1.2.0rc2`` requires ``warp-lang==1.13.0``, ``mujoco==3.8.0``, | ||
| and ``mujoco-warp==3.8.0.1``. ``warp-lang``/``mujoco``/``mujoco-warp`` | ||
| pins live in :mod:`isaaclab` and ``tools/wheel_builder/res/python_packages.toml``; | ||
| the Newton pin is mirrored across :mod:`isaaclab_newton`, | ||
| :mod:`isaaclab_visualizers` (3×), :mod:`isaaclab_physx` (``[newton]`` | ||
| extra), and the wheel-builder TOML. | ||
| * Updated ``wp.math.transform_to_matrix`` to ``wp.transform_to_matrix`` in | ||
| :mod:`~isaaclab_newton.physics.newton_manager` and | ||
| :mod:`~isaaclab_ov.renderers.ovrtx_renderer_kernels` to match the | ||
| ``warp-lang`` 1.13 API (the ``wp.math`` namespace was removed). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Bumped the optional ``[newton]`` extra to ``v1.2.0rc2`` so the Newton | ||
| scene representation built by | ||
| :class:`~isaaclab_physx.scene_data_providers.PhysxSceneDataProvider` | ||
| for the OV/Rerun/Viser visualizers stays in sync with the version | ||
| pinned in :mod:`isaaclab_newton` and :mod:`isaaclab_visualizers`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StafaH - looks like Jichuan included the bvh update in this PR. could you take a look to see if this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct but works. Ideally we want to now move the bvh build and refit outside of the renderer. In 1.2 there is a deprecation path that builds a bvh and refits it to keep old behaviour, so we can just call the original code and newton should handle building if it does not exist.