Skip to content

Disables articulation tests in Isaac Sim CI#5557

Merged
kellyguo11 merged 2 commits into
isaac-sim:developfrom
kellyguo11:disable-articulation-sim-ci
May 9, 2026
Merged

Disables articulation tests in Isaac Sim CI#5557
kellyguo11 merged 2 commits into
isaac-sim:developfrom
kellyguo11:disable-articulation-sim-ci

Conversation

@kellyguo11
Copy link
Copy Markdown
Contributor

Description

articulation tests have been timing out in CI. disabling it to unblock isaac sim MR merging until we figure out why the timeouts are happening.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label May 9, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 9, 2026

Greptile Summary

This PR removes the @pytest.mark.isaacsim_ci marker from all articulation tests in both isaaclab_physx and isaaclab_newton to prevent them from being selected by the CI suite while timeout issues are investigated.

  • All @pytest.mark.isaacsim_ci markers are stripped from every test function in both files (~28 in isaaclab_physx, ~22 in isaaclab_newton); a quick search confirms zero remaining occurrences in either file.
  • This is an explicitly temporary workaround with no linked tracking issue; once the root-cause of the timeouts is identified, these markers will need to be restored.

Confidence Score: 5/5

Safe to merge; the change only removes pytest markers from test files and cannot affect production code or runtime behaviour.

Both files are fully cleaned — zero isaacsim_ci markers remain after the change. The removal is mechanically correct and consistent across both packages. The only open question is the missing tracking mechanism for restoring the tests later, but that is a process concern rather than a defect in the code itself.

No files require special attention; changes are limited to pytest marker annotations in two test files.

Important Files Changed

Filename Overview
source/isaaclab_physx/test/assets/test_articulation.py Removes @pytest.mark.isaacsim_ci from ~28 test functions; no marker instances remain in the file, change is complete and consistent.
source/isaaclab_newton/test/assets/test_articulation.py Removes @pytest.mark.isaacsim_ci from ~22 test functions; no marker instances remain in the file, change is complete and consistent.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Pipeline triggers pytest] --> B{Marker filter: isaacsim_ci?}
    B -- Before PR --> C[Collect all tests with @pytest.mark.isaacsim_ci ~50 articulation tests selected]
    B -- After PR --> D[No tests match isaacsim_ci in test_articulation.py files 0 articulation tests run]
    C --> E[Tests run → timeouts in CI]
    D --> F[CI unblocked; articulation tests skipped until root cause is resolved]
Loading

Reviews (1): Last reviewed commit: "add changelog fragments" | Re-trigger Greptile

@kellyguo11 kellyguo11 merged commit 1e0e379 into isaac-sim:develop May 9, 2026
32 of 34 checks passed
hujc7 added a commit to hujc7/IsaacLab that referenced this pull request May 11, 2026
NewtonArticulationData._create_simulation_bindings rebound
_sim_bind_root_com_vel_w / _sim_bind_body_com_vel_w on every reset,
including when get_root_velocities / get_link_velocities returned None
for fixed-base articulations. The first call left a wp.zeros fallback
allocated by _create_buffers, but every subsequent sim.reset() then
overwrote that fallback with None, so _pin_proxy_arrays crashed:

    TypeError: ProxyArray expects a warp.array, got NoneType.

Reproduces with any panda test that calls sim.reset() twice (e.g.
test_write_joint_frictions_to_sim) once the Newton articulation tests
were re-enabled in the regular CI suite by isaac-sim#5557.
Only assign the binding when the solver actually exposes one; otherwise
let the existing wp.zeros fallback persist.

Also wire model.articulation_count / max_joints_per_articulation /
max_dofs_per_articulation / joint_dof_count / body_count into the mock
NewtonManager used by test_articulation_iface; the task-space scratch
buffers added in this PR consume those sizes during data init and would
otherwise pick up MagicMock placeholders, triggering reshape mismatches
in wp.zeros / wp.array.reshape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant