Skip to content

Updates robomimic config for Franka-Lift environment#69

Merged
Mayankm96 merged 1 commit into
isaac-sim:mainfrom
yangcyself:bugfix-68-mismatch-robomimic
Apr 23, 2023
Merged

Updates robomimic config for Franka-Lift environment#69
Mayankm96 merged 1 commit into
isaac-sim:mainfrom
yangcyself:bugfix-68-mismatch-robomimic

Conversation

@yangcyself
Copy link
Copy Markdown
Contributor

Description

  1. Enlarge the hard-coded success range from 0.002 to 0.02 so that it's possible for a human operator to succeed.
  2. Update from object_positions to object_relative_tool_positions in lift_bc.json and lift_bcq.json, to match with the configuration in lift_cfg.py

Fixes #68

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation: Not applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works: Not applicable
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file: Not applicable

Enlarge the hard coded success range from 0.002 to 0.02
Update from object_positions to object_relative_tool_positions in bc obs
@Mayankm96
Copy link
Copy Markdown
Contributor

Are you able to train a policy through imitation learning with these changes?

I think in the earlier version, object_positions were the object pose in the environment frame, not relative to tool frame.

@yangcyself
Copy link
Copy Markdown
Contributor Author

I actually did not succeed in training a policy to grab the tube with behavior cloning. But I thought it was because of the bad demonstrations I provided.

And yes, in the earlier version object_positions was used in lift_cfg.py but you changed it to object_relative_tool_positions in #33 (link), so I thought we need to update and use object_relative_tool_positions in imitation learning.

So maybe it's better to stick to the previous setting and use object_positions? So what I should do it's to config the observation to collect object_positions in the data collection step, by changing the file collect_demonstrations.py?

@Mayankm96 Mayankm96 changed the title update lift config and env making it feasible Updates robomimic config for Franka-Lift environment Apr 17, 2023
@Mayankm96
Copy link
Copy Markdown
Contributor

Mayankm96 commented Apr 17, 2023

Training with human data can indeed be challenging. I recommend checking this paper on tips for imitation learning

https://arxiv.org/abs/2108.03298

Maybe to check if the observations make sense, you can collect data with the state machine and see how it performs. It would be easier to collect data that way.

I will test your PR later this week or early next week.

@Mayankm96 Mayankm96 added the bug Something isn't working label Apr 17, 2023
@Mayankm96 Mayankm96 self-requested a review April 17, 2023 20:50
Copy link
Copy Markdown
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would need to attempt re-training again but will do that when the time comes.

@Mayankm96 Mayankm96 merged commit 629136c into isaac-sim:main Apr 23, 2023
Mayankm96 pushed a commit that referenced this pull request Apr 15, 2024
# Description

Adds in unittests for terrain importers. check that all three import
function work and generate meshes of correct size and the balls dropped
on mesh do not fall through it.

Fixes #54

## Type of Change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file

---------

Signed-off-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com>
Co-authored-by: James Smith <jsmith@theaiinstitute.com>
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
…c-sim#69)

# Description

Adds in unittests for terrain importers. check that all three import
function work and generate meshes of correct size and the balls dropped
on mesh do not fall through it.

Fixes isaac-sim#54

## Type of Change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file

---------

Signed-off-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com>
Co-authored-by: James Smith <jsmith@theaiinstitute.com>
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
…c-sim#69)

# Description

Adds in unittests for terrain importers. check that all three import
function work and generate meshes of correct size and the balls dropped
on mesh do not fall through it.

Fixes isaac-sim#54

## Type of Change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file

---------

Signed-off-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com>
Co-authored-by: James Smith <jsmith@theaiinstitute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Mismatch in the observations between data collection and training in robomimic example workflow

2 participants