Allowing initiator of a conversation to resolve it

[thomasklemm]

I've recently had a case where I commented on a pull request in a public GitHub repository that I don't have write access too, and where I'm not the user opening the PR.

After the user who opened the PR addressed some of the feedback I wanted to go ahead and mark the conversations as resolved, but was surprised not to find the "Resolve conversation" button.

As per the docs, it's right now only possible to resolve a conversation if you opened the pull request or if you have write access to the repository where the pull request was opened.

I think it would be reasonable to allow the person who initiated a conversation by commenting on a PR to also allow to resolve that conversation. This allows for cases where you think your comment has been addressed, and also if you changed your mind to leave a command and mark the conversation as resolved (plus all other cases where you just want to say "This conversation is resolved from my point of view" as the initiator of the conversation). WDYT?

---

Example from the UI to show that the "Resolve conversation" button is missing.

[matthijskooijman]

I was also looking for the same feature, so I just sent a request to GH about it:

I have a small feature suggestion. Currently only PR authors and users with repo write access can resolve a conversation of comments in a pullrequest. I would suggest also allowing the user that started a conversation to resolve it again.

This fits well in a workflow where a reviewer adds a comment because something needs to be fixed or clarified, the PR author applies a fix and then the reviewer verifies the fix and resolves the conversation when they are satisfied the issue is fixed adequately. This workflow currently works for reviewers with repo write access, but external reviewers are dependent on either the PR author or a committer to resolve things, which is not ideal in this workflow.

Please consider adding this feature at some point.

Files as ticket 1163167