Always make fs.Stats’ .uid and .gid fields unsigned
#87
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of writing, all currently published versions of Node.js return signed 32-bit integers in their return values for the `uid` and `gid` fields of `fs.Stats` instances. This is problematic, because some of Node’s other `fs` methods like `chown` expect unsigned 32-bit integer input and throw when encountering negative integers; this has broken e.g. `sudo npm install -g` on `OS X`, where `nobody` has a UID that would be returned as `-2` by `fs.stat()`. Ref: nodejs/node#8515 Ref: npm/npm#13918
manjaneqx
reviewed
Oct 22, 2023
| fs.fstatSync = statFixSync(fs.fstatSync) | ||
| fs.lstatSync = statFixSync(fs.lstatSync) | ||
|
|
||
| // if lchmod/lchown do not exist, then make them no-ops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of writing, all currently published versions of Node.js return signed 32-bit integers in their return values for the
uidandgidfields offs.Statsinstances.This is problematic, because some of Node’s other
fsmethods likechownexpect unsigned 32-bit integer input and throw when encountering negative integers; this has broken e.g.sudo npm install -gonOS X, wherenobodyhas a UID that would be returned as-2byfs.stat().Ref: nodejs/node#8515
Ref: npm/npm#13918