-
Notifications
You must be signed in to change notification settings - Fork 64
Add a function to compute a radar grid that spans an input geocoded grid (MCR #90132) #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to compute a radar grid that spans an input geocoded grid (MCR #90132) #99
Conversation
Expose the C++ constants `isce3::core::GLOBAL_MIN_HEIGHT` and `isce3::core::GLOBAL_MAX_HEIGHT` to Python.
See the discussion on this comment: https://github-fn.jpl.nasa.gov/isce-3/isce/pull/2097#discussion_r26503
This doesn't work in Python >=3.9 until Python 3.11. Multiple inheritance with `NamedTuple` has limited support. See: * python/cpython#19363 * python/cpython#88089 * python/cpython#92027
|
@gshiroma @nemo794 this is a copy of a PR that was approved on the internal GitHub server: https://github-fn.jpl.nasa.gov/isce-3/isce/pull/2097 |
gshiroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This PR was reviewed internally. Thank you, @gmgunter . Just make sure that the unit tests pass.
nemo794
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a new function
isce3.geometry.get_bounding_radar_grid()that returns aRadarGridParametersobject that spans an inputGeoGridParametersobject. The output radar grid is the smallest radar grid that contains all points within the input geocoded grid over a user-specified height range. Additional margin may be added to extend the radar grid azimuth & range extents.This functionality is useful for implementing the static layers workflow. Many of the layers in the static layers product are computed from an input radar grid, but the input to the static layers workflow is a geo grid -- not a radar grid. Therefore we will need the ability to compute a radar grid that spans the input geo grid.