Code and documentation string cleanup#10
Open
grlee77 wants to merge 15 commits intoismrmrd:masterfrom
Open
Conversation
ismrmrdtools/__init__.py
Outdated
Contributor
There was a problem hiding this comment.
This is a bug. You're missing a comma between "grappa" and "ndarray_io".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to follow standard PEP8 code formatting conventions and change to the numpy docstring format as discussed in #8.
No changes to functionality have been made, but a few changes were not purely stylistic:
assertstatements with explicit exceptions (e.g.raise ValueError(...))reloadin the examplesfrom __future__ import division, print_function, absolute_importis used throughout with // used to explicitly specify integer division where necessary.I ran the current examples successfully in both Python 3.4 and Python 2.7, except for a couple I did not have data for (see #9).
Ideally, the remaining two examples should be run with proper data to make sure nothing was inadvertently broken by these changes prior to merging.