Distinguish upstream errors from local error for outlier detection#1662
Distinguish upstream errors from local error for outlier detection#1662kidiyoor wants to merge 1 commit intoistio:masterfrom
Conversation
kidiyoor
requested review from
dcberg,
duderino,
linsun,
louiscryan,
nrjpoddar,
rshriram and
smawson
as code owners
|
😊 Welcome @kidiyoor! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
googlebot
added
the
cla: yes
istio-testing
added
size/L
|
Hi @kidiyoor. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // no effect. | ||
| google.protobuf.UInt32Value consecutive_5xx_errors = 7; | ||
|
|
||
| // The % chance that a host will be actually ejected when an outlier status is |
There was a problem hiding this comment.
@rshriram this is adding more configuration elements from envoy directly here. They will be passed along almost verbatim. Do we need some different for DR that is half way between and EnvoyFilter and full schematization?
|
@kidiyoor: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
howardjohn
removed
the
cla: yes
|
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2020-09-29. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
istio-policy-bot
added
the
lifecycle/automatically-closed
6 participants
Subject: Allow to eject hosts when ONLY local origin errors are seen.
Description:
Currently exposed configuration doesn't allow to only consider local connect error, timeout error etc for outlier detection. This feature is needed if application workload is like a proxy and we want to failover only when the application is irresponsive and not the target. Envoy seen to support this feature already - envoyproxy/envoy#4822.
k8s[ envoy(ingress) -> application ] -> target