Skip to content

mixerfilter: add forwarded attributes to per-route config #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyessenov merged 3 commits into from
May 23, 2018
Merged

mixerfilter: add forwarded attributes to per-route config #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db8e42
add forward attributes to service config
kyessenov May 16, 2018
c3ce383
clarify
kyessenov May 17, 2018
6585537
clarify order of application
kyessenov May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 138 additions & 74 deletions mixer/v1/config/client/client_config.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions mixer/v1/config/client/client_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ message ServiceConfig {

// Send these attributes to Mixer in both Check and Report. This
// typically includes the "destination.service" attribute.
// In case of a per-route override, per-route attributes take precedence
// over the attributes supplied in the client configuration.
Attributes mixer_attributes = 3;

// HTTP API specifications to generate API attributes.
Expand All @@ -73,6 +75,20 @@ message ServiceConfig {
// [mesh-level
// policy][istio.mixer.v1.config.client.TransportConfig.network_fail_policy].
NetworkFailPolicy network_fail_policy = 7;

// Default attributes to forward to upstream. This typically
// includes the "source.ip" and "source.uid" attributes.
// In case of a per-route override, per-route attributes take precedence
// over the attributes supplied in the client configuration.
//
// Forwarded attributes take precedence over the static Mixer attributes.
// The full order of application is as follows:
// 1. static Mixer attributes from the filter config;
// 2. static Mixer attributes from the route config;
// 3. forwarded attributes from the source filter config (if any);
// 4. forwarded attributes from the source route config (if any);
// 5. derived attributes from the request metadata.
Attributes forward_attributes = 8;
}

// Defines the transport config on how to call Mixer.
Expand Down
Loading