Skip to content

Add mesh config to allow setting network policy fail open#674

Closed
yangminzhu wants to merge 1 commit into
istio:release-1.1from
yangminzhu:failOpen_1_1
Closed

Add mesh config to allow setting network policy fail open#674
yangminzhu wants to merge 1 commit into
istio:release-1.1from
yangminzhu:failOpen_1_1

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

Cherrypick #670 to 1.1 branch.

istio/istio#9483, istio/istio#9485

@istio-testing istio-testing requested a review from costinm October 23, 2018 23:34
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 23, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu

If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu
Copy link
Copy Markdown
Contributor Author

/test api-presubmit

@rshriram
Copy link
Copy Markdown
Member

I have another PR that picks out other features as well. Lets use that.

@rshriram rshriram closed this Oct 24, 2018
@yangminzhu yangminzhu deleted the failOpen_1_1 branch October 24, 2018 19:12
@yangminzhu
Copy link
Copy Markdown
Contributor Author

@rshriram thanks, will you also pick the change for pilot in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants