Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 107 additions & 54 deletions mesh/v1alpha1/config.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion mesh/v1alpha1/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,13 @@ message MeshConfig {
// will be used to generate key/cert eventually. This isn't supported for non-k8s case.
bool enable_sds_token_mount = 23;

// The trust domain corresponds to the trust root of a system.
// Refer to https://github.com/spiffe/spiffe/blob/master/standards/SPIFFE-ID.md#21-trust-domain
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected behavior if this is not set?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment // Fallback to old identity format(without trust domain) if not set.

// Fallback to old identity format(without trust domain) if not set.
string trust_domain = 26;

// $hide_from_docs
// Next available field number: 26
// Next available field number: 27
}

// ConfigSource describes information about a configuration store inside a
Expand Down
10 changes: 10 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,16 @@ <h2 id="MeshConfig">MeshConfig</h2>
rules, and other Istio configuration artifacts. Multiple data sources
can be configured for a single control plane.</p>

</td>
</tr>
<tr id="MeshConfig-trust_domain">
<td><code>trustDomain</code></td>
<td><code>string</code></td>
<td>
<p>The trust domain corresponds to the trust root of a system.
Refer to https://github.com/spiffe/spiffe/blob/master/standards/SPIFFE-ID.md#21-trust-domain
Fallback to old identity format(without trust domain) if not set.</p>

</td>
</tr>
</tbody>
Expand Down
5 changes: 5 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,11 @@
"id": 23,
"name": "enable_sds_token_mount",
"type": "bool"
},
{
"id": 26,
"name": "trust_domain",
"type": "string"
}
],
"reserved_ids": [
Expand Down
23 changes: 15 additions & 8 deletions python/istio_api/mesh/v1alpha1/config_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.