Skip to content

API changes to enable TCP keepalive configuration. #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 3 commits into from
Nov 25, 2018
Merged

API changes to enable TCP keepalive configuration. #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cc0b21
API changes to enable TCP keepalive configuration.
shakti-das Nov 21, 2018
924d6d5
Added probes configuration to tcp_keepalive.
shakti-das Nov 21, 2018
f0b6350
Updated description to 'time duration'.
shakti-das Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
201 changes: 131 additions & 70 deletions mesh/v1alpha1/config.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion mesh/v1alpha1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ message MeshConfig {
// Connection timeout used by Envoy. (MUST BE >=1ms)
google.protobuf.Duration connect_timeout = 6;

// If set then set SO_KEEPALIVE on the socket to enable TCP Keepalives.
istio.networking.v1alpha3.ConnectionPoolSettings.TCPSettings.TcpKeepalive tcp_keepalive = 28;

// Class of ingress resources to be processed by Istio ingress
// controller. This corresponds to the value of
// "kubernetes.io/ingress.class" annotation.
Expand Down Expand Up @@ -197,7 +200,7 @@ message MeshConfig {
string trust_domain = 26;

// $hide_from_docs
// Next available field number: 28
// Next available field number: 29
}

// ConfigSource describes information about a configuration store inside a
Expand Down
8 changes: 8 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,14 @@ <h2 id="MeshConfig">MeshConfig</h2>
<td>
<p>Connection timeout used by Envoy. (MUST BE &gt;=1ms)</p>

</td>
</tr>
<tr id="MeshConfig-tcp_keepalive">
<td><code>tcpKeepalive</code></td>
<td><code><a href="https://istio.io/docs/reference/config/istio.networking.v1alpha3.html#ConnectionPoolSettings-TCPSettings-TcpKeepalive">istio.networking.v1alpha3.ConnectionPoolSettings.TCPSettings.TcpKeepalive</a></code></td>
<td>
<p>If set then set SO_KEEPALIVE on the socket to enable TCP Keepalives.</p>

</td>
</tr>
<tr id="MeshConfig-ingress_class">
Expand Down
Loading