Skip to content

Add Mixer Report Session Affinity into Mesh Config #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 2 commits into from
Jan 3, 2019
Merged

Add Mixer Report Session Affinity into Mesh Config #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7670a31
add session affinity option.
bianpengyuan Jan 3, 2019
2c6b1d5
proto lock
bianpengyuan Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 127 additions & 80 deletions mesh/v1alpha1/config.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion mesh/v1alpha1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ message MeshConfig {
// to connect to Mixer.
bool policy_check_fail_open = 25;

// Enable session affinity for envoy mixer reports so that calls from a proxy will
// always target the same mixer instance.
bool report_session_affinity = 31;
Copy link
Copy Markdown
Member

@rshriram rshriram Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this have to have a config option? Also, this is very badly named.. It reads like "inform me of all the session affinity stuff in the mesh!"

Copy link
Copy Markdown
Contributor Author

@bianpengyuan bianpengyuan Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It controls telemetry cluster service discovery to be strict_dns or eds. For name, how about telemetry_report_session_affinity?

Copy link
Copy Markdown
Member

@rshriram rshriram Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidecar_to_telemetry_session_affinity ?


// Port on which Envoy should listen for incoming connections from
// other services.
int32 proxy_listen_port = 4;
Expand Down Expand Up @@ -243,7 +247,7 @@ message MeshConfig {
DefaultServiceDependency default_service_dependency = 29;

// $hide_from_docs
// Next available field number: 31
// Next available field number: 32
}

// ConfigSource describes information about a configuration store inside a
Expand Down
9 changes: 9 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,15 @@ <h2 id="MeshConfig">MeshConfig</h2>
Default is false which means the traffic is denied when the client is unable
to connect to Mixer.</p>

</td>
</tr>
<tr id="MeshConfig-report_session_affinity">
<td><code>reportSessionAffinity</code></td>
<td><code>bool</code></td>
<td>
<p>Enable session affinity for envoy mixer reports so that calls from a proxy will
always target the same mixer instance.</p>

</td>
</tr>
<tr id="MeshConfig-proxy_listen_port">
Expand Down
5 changes: 5 additions & 0 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,11 @@
"name": "policy_check_fail_open",
"type": "bool"
},
{
"id": 31,
"name": "report_session_affinity",
"type": "bool"
},
{
"id": 4,
"name": "proxy_listen_port",
Expand Down
Loading