Skip to content

Cherry pick #772 from release-1.1 into master#773

Closed
JimmyCYJ wants to merge 1 commit intoistio:masterfrom
JimmyCYJ:merge-sds-name
Closed

Cherry pick #772 from release-1.1 into master#773
JimmyCYJ wants to merge 1 commit intoistio:masterfrom
JimmyCYJ:merge-sds-name

Conversation

@JimmyCYJ
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ commented Jan 24, 2019

  • Add sds_name into gateway config

  • Update comment

  • Update comment

@JimmyCYJ
Add sds_name into gateway config. (istio#772)
3b79300 
* Add sds_name into gateway config

* Update comment

* Update comment
@JimmyCYJ JimmyCYJ requested a review from hklai January 24, 2019 18:39
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 24, 2019
@JimmyCYJ JimmyCYJ changed the title Cherry pick https://github.com/istio/api/pull/772 from release-1.1 into master Cherry pick #772 from release-1.1 into master Jan 24, 2019
@JimmyCYJ JimmyCYJ requested a review from wenchenglu January 24, 2019 18:40
@wenchenglu
Copy link
Copy Markdown

wenchenglu commented Jan 24, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 24, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JimmyCYJ, wenchenglu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren

If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ JimmyCYJ requested a review from costinm January 24, 2019 22:17
rshriram
rshriram suggested changes Jan 27, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the comments from #772 before merging this to master.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jan 27, 2019

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Jan 27, 2019
@JimmyCYJ
Copy link
Copy Markdown
Member Author

JimmyCYJ commented Jan 28, 2019 •
edited
Loading

please resolve the comments from #772 before merging this to master.

For single host defined in gateway, we can support implicit naming. Customer can either specify sdsName explicitly or let Pilot pick the first Host name as sds resource name. For multiple hosts, we suggest customer to use the sdsName. We can enforce that in config validation. If customer defines multiple gateways, we also suggest customer to specify sdsName in each gateway. If one host name appears in gateway A and gateway B with different key/cert pairs, using different sdsName allows gateway A and B get different key/cert pairs. cc @myidpt @costinm

@JimmyCYJ JimmyCYJ modified the milestone: 1.1 Jan 28, 2019
@JimmyCYJ JimmyCYJ closed this Feb 1, 2019
@JimmyCYJ JimmyCYJ deleted the merge-sds-name branch February 1, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hklai hklai Awaiting requested review from hklai

@diemtvu diemtvu Awaiting requested review from diemtvu

@mandarjog mandarjog Awaiting requested review from mandarjog

@wenchenglu wenchenglu Awaiting requested review from wenchenglu

@costinm costinm Awaiting requested review from costinm

1 more reviewer

@rshriram rshriram rshriram requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wenchenglu wenchenglu

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/hold Block automatic merging of a PR. review/done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JimmyCYJ @wenchenglu @istio-testing @rshriram @duderino @googlebot