Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 101 additions & 43 deletions networking/v1alpha3/gateway.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions networking/v1alpha3/gateway.proto
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,18 @@ message Server {
// client side certificate.
string ca_certificates = 5;

// The credentialName stands for a unique identifier that can be used
// to identify the serverCertificate, the privateKey and the
// CaCertificates associated with this server. Gateway workloads
// capable of fetching credentials from a remote credential store will
// be configured to retrive the credentials using this name, instead of
// using the file system paths specified above. The semantics of the
// name are platform dependent. In Kubernetes, the default Istio
// supplied credentail server expects the credentialName to match the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rshriram doc needs a little work :)

// name of the Kubernetes secret that holds the server certificate, the
// private key, and the CA certificate (if using mutual TLS).
string credential_name = 10;

// A list of alternate names to verify the subject identity in the
// certificate presented by the client.
repeated string subject_alt_names = 6;
Expand Down
17 changes: 17 additions & 0 deletions networking/v1alpha3/istio.networking.v1alpha3.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3323,6 +3323,11 @@
"name": "ca_certificates",
"type": "string"
},
{
"id": 10,
"name": "credential_name",
"type": "string"
},
{
"id": 6,
"name": "subject_alt_names",
Expand Down
Loading