Skip to content

Fix sample code in HTML reference docs#862

Closed
esimons wants to merge 1 commit intoistio:masterfrom
esimons:patch-1
Closed

Fix sample code in HTML reference docs#862
esimons wants to merge 1 commit intoistio:masterfrom
esimons:patch-1

Conversation

@esimons
Copy link
Copy Markdown

@esimons esimons commented Mar 15, 2019

Updating cookie matcher example to align with testdata: https://github.com/istio/istio/blob/master/tests/testdata/config/virtual-service-all.yaml#L18

Pasting here since diff is too big for preview:

  http:
  - match:
    - headers:
        cookie:
-         user: dev-123
+         regex: "^(.*?;)?(user=dev-123)(;.*)?"

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 15, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @esimons. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@venilnoronha venilnoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make the changes in the proto file and then generate this html using make commands.

@esimons
Copy link
Copy Markdown
Author

esimons commented Mar 18, 2019

@venilnoronha it doesn't appear that this is a generated file. As a sanity check, I just did a project search for what's being replaced and came up empty.

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 18, 2019
@venilnoronha
Copy link
Copy Markdown
Member

It's probably being generated from the following line.

// exact: "user=dev-123"

@esimons
Copy link
Copy Markdown
Author

esimons commented Mar 18, 2019

After doing a bit of digging, it seems like this file should actually be deleted entirely following #811, since it's no longer generated via makefile and appears to have been broken down into multiple pages.
Perhaps @geeknoid @rshriram can confirm?

@geeknoid
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esimons, geeknoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid
Copy link
Copy Markdown
Contributor

Replaced by #866 which deletes the file.

@geeknoid geeknoid closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants