Fix sample code in HTML reference docs#862
Fix sample code in HTML reference docs#862esimons wants to merge 1 commit intoistio:masterfrom esimons:patch-1
Conversation
Updating cookie matcher example to align with testdata: https://github.com/istio/istio/blob/master/tests/testdata/config/virtual-service-all.yaml#L18
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Hi @esimons. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
venilnoronha
left a comment
There was a problem hiding this comment.
You need to make the changes in the proto file and then generate this html using make commands.
|
@venilnoronha it doesn't appear that this is a generated file. As a sanity check, I just did a project search for what's being replaced and came up empty. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
It's probably being generated from the following line. api/networking/v1alpha3/gateway.proto Line 120 in f5ccf50 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: esimons, geeknoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Replaced by #866 which deletes the file. |
Updating cookie matcher example to align with testdata: https://github.com/istio/istio/blob/master/tests/testdata/config/virtual-service-all.yaml#L18
Pasting here since diff is too big for preview:
http: - match: - headers: cookie: - user: dev-123 + regex: "^(.*?;)?(user=dev-123)(;.*)?"