Add upstream and downstream info in parent read callbacks in tcp too(#9949)#150
Merged
kyessenov merged 2 commits intoistio:release-1.5from Feb 18, 2020
Merged
Add upstream and downstream info in parent read callbacks in tcp too(#9949)#150kyessenov merged 2 commits intoistio:release-1.5from
kyessenov merged 2 commits intoistio:release-1.5from
Conversation
…nvoyproxy#9949) Signed-off-by: gargnupur <gargnupur@google.com>
Member
|
@istio/release-managers-1-5 seems you are not owners here |
Member
|
is this in master? |
Author
|
@howardjohn : No, release 1.5 because that's what proxy/release 1.5 is based of |
kyessenov
approved these changes
Feb 18, 2020
Author
|
Envoy builds successfully (bazel build //source/exe:envoy-static)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gargnupur gargnupur@google.com
Ref: istio/istio#20802
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: git cherry-pick fade668
Upstream envoy PR: envoyproxy#9949
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]
12 lines of non-test code changes.
Rest is test.