Skip to content

Set release managers as CODEOWNERS for release-1.7#239

Merged
istio-testing merged 1 commit intorelease-1.7from
release-1.7-codeowners
Jul 25, 2020
Merged

Set release managers as CODEOWNERS for release-1.7#239
istio-testing merged 1 commit intorelease-1.7from
release-1.7-codeowners

Conversation

@jwendell
Copy link
Copy Markdown
Member

No description provided.

@jwendell
Copy link
Copy Markdown
Member Author

/retest

@PiotrSikora
Copy link
Copy Markdown

/retest

@PiotrSikora
Copy link
Copy Markdown

ASan is consistently failing in //test/extensions/filters/udp/dns_filter:dns_filter_integration_test.

@lizan @rshriram any ideas?

@dmitri-d
Copy link
Copy Markdown

dmitri-d commented Jul 22, 2020

At a quick glance the ASAN test failure in dns_filter_integration_test is in libc++. FWIW, all *SAN tests should be used with appropriately instumented libc, but that will increase CI memory usage.

@dmitri-d
Copy link
Copy Markdown

It appears that the 1.7 branch is missing the recent CI-related fixes for tsan tests (envoyproxy#12134), which should at least resolve tsan flakes (vhds_integration_test is one).

@jwendell
Copy link
Copy Markdown
Member Author

I have cherry-picked that PR into 1.7, let's see if that fixes the issues: #241

@PiotrSikora
Copy link
Copy Markdown

It's ASan that's failing here, so TSan fix won't fix it.

@jwendell
Copy link
Copy Markdown
Member Author

that's right. I closed it.

@jwendell jwendell force-pushed the release-1.7-codeowners branch from f9ed575 to bf8043f Compare July 25, 2020 02:54
@istio-testing istio-testing merged commit 11f71ff into release-1.7 Jul 25, 2020
@delete-merged-branch delete-merged-branch Bot deleted the release-1.7-codeowners branch July 25, 2020 03:49
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 19, 2021
…io#239)

Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code)

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
…io#239)

Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code)

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants