Skip to content

ignore verification if peer/origin optional fields are set#1660

Merged
quanjielin merged 3 commits into
istio:release-0.8from
quanjielin:quanlinign1
May 1, 2018
Merged

ignore verification if peer/origin optional fields are set#1660
quanjielin merged 3 commits into
istio:release-0.8from
quanjielin:quanlinign1

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin commented Apr 30, 2018

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 30, 2018
@quanjielin quanjielin requested review from diemtvu and qiwzhang and removed request for JimmyCYJ and sebastienvas May 1, 2018 00:12
qiwzhang
qiwzhang reviewed May 1, 2018
View reviewed changes
Comment thread src/envoy/http/authn/http_filter_test.cc
iaapi::Policy policy_;

Http::TestHeaderMapImpl request_headers_;
StrictMock<MockAuthenticationFilter> filter_{filter_config_};
Copy link
Copy Markdown
Contributor

@qiwzhang qiwzhang May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constructing in line 110 and line 106 never used due to line 85. remove them

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented May 1, 2018

/lgtm
/approve

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented May 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented May 1, 2018

Automatic merge from submit-queue.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented May 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented May 1, 2018

/lgtm cancel
/approve cancel

@istio-testing istio-testing removed the lgtm label May 1, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented May 1, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: qiwzhang

Assign the PR to them by writing /assign @qiwzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiwzhang
Copy link
Copy Markdown
Contributor

qiwzhang commented May 1, 2018

Please move this PR into release-0.8 branch

@quanjielin quanjielin changed the base branch from master to release-0.8 May 1, 2018 16:48
@quanjielin quanjielin merged commit 55ac706 into istio:release-0.8 May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemtvu diemtvu Awaiting requested review from diemtvu

1 more reviewer

@qiwzhang qiwzhang qiwzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiwzhang qiwzhang

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@quanjielin @qiwzhang @istio-merge-robot @istio-testing @googlebot