Use mTLS mode enum to decide authentication result. by diemtvu · Pull Request #1733 · istio/proxy

diemtvu · 2018-05-04T20:26:34Z

We want to support different authentication mode in order to support mTLS migrations.

googlebot · 2018-05-04T20:26:37Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

incfly

/lgtm
/approve

googlebot · 2018-05-04T22:55:25Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-05-04T22:56:55Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

qiwzhang · 2018-05-07T21:29:40Z

+    case iaapi::MutualTls::STRICT:
+      return has_user;
+    default:
+      ENVOY_LOG(warn, "Invalid mTLS mode {}",


use NOT_REACHED

defined in common/common/assert.h

qiwzhang · 2018-05-07T22:45:16Z

/lgtm
/approve

googlebot · 2018-05-07T23:26:33Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

diemtvu · 2018-05-08T15:28:02Z

/test all

diemtvu · 2018-05-08T15:28:41Z

/retest

googlebot · 2018-05-09T18:51:10Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-05-09T18:51:33Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

qiwzhang · 2018-05-09T21:24:18Z

/lgtm
/approve

googlebot · 2018-05-09T21:32:22Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-05-09T22:03:15Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

diemtvu · 2018-05-09T22:22:49Z

/retest

qiwzhang · 2018-05-09T22:41:25Z

/lgtm
/approve

istio-testing · 2018-05-09T22:41:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incfly, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiwzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

diemtvu requested review from incfly and qiwzhang May 4, 2018 20:26

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 4, 2018

incfly reviewed May 4, 2018

View reviewed changes

istio-testing assigned incfly May 4, 2018

istio-testing added the lgtm label May 4, 2018

diemtvu added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 4, 2018

diemtvu force-pushed the r08 branch from 366c160 to 7bb01ad Compare May 4, 2018 22:56

istio-testing removed the lgtm label May 4, 2018

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels May 4, 2018

diemtvu force-pushed the r08 branch from 7bb01ad to 1b59a2c Compare May 7, 2018 21:09

qiwzhang reviewed May 7, 2018

View reviewed changes

istio-testing assigned qiwzhang May 7, 2018

istio-testing added lgtm and removed lgtm labels May 7, 2018

diemtvu added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 7, 2018

diemtvu added the lgtm label May 7, 2018

istio-testing removed the lgtm label May 9, 2018

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels May 9, 2018

diemtvu added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 9, 2018

istio-testing added the lgtm label May 9, 2018

istio-testing and others added 5 commits May 9, 2018 14:31

Update_Dependencies (istio#1657)

93ce9ad

Use mTLS mode enum to decide authentication result.

a8f88fa

Clang

55c5d75

Use NOT_REACHED macros for default case.

288d25c

Clang

407fcf8

diemtvu force-pushed the r08 branch from 08b1e6c to 407fcf8 Compare May 9, 2018 21:32

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels May 9, 2018

diemtvu added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 9, 2018

diemtvu removed the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 9, 2018

qiwzhang approved these changes May 9, 2018

View reviewed changes

qiwzhang merged commit 61c5a39 into istio:release-0.8 May 9, 2018

Conversation

diemtvu commented May 4, 2018

Uh oh!

googlebot commented May 4, 2018

Uh oh!

incfly left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented May 4, 2018

Uh oh!

googlebot commented May 4, 2018

Uh oh!

qiwzhang May 7, 2018

Choose a reason for hiding this comment

Uh oh!

diemtvu May 7, 2018

Choose a reason for hiding this comment

Uh oh!

qiwzhang commented May 7, 2018

Uh oh!

googlebot commented May 7, 2018

Uh oh!

diemtvu commented May 8, 2018

Uh oh!

diemtvu commented May 8, 2018

Uh oh!

googlebot commented May 9, 2018

Uh oh!

googlebot commented May 9, 2018

Uh oh!

qiwzhang commented May 9, 2018

Uh oh!

googlebot commented May 9, 2018

Uh oh!

googlebot commented May 9, 2018

Uh oh!

diemtvu commented May 9, 2018

Uh oh!

qiwzhang commented May 9, 2018

Uh oh!

istio-testing commented May 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants