Skip to content

Strip debug info for release#1738

Merged
hklai merged 1 commit into
istio:release-0.8from
qiwzhang:r08-strip
May 8, 2018
Merged

Strip debug info for release#1738
hklai merged 1 commit into
istio:release-0.8from
qiwzhang:r08-strip

Conversation

@qiwzhang
Copy link
Copy Markdown
Contributor

@qiwzhang qiwzhang commented May 8, 2018

What this PR does / why we need it:

For istio/istio#5477

Special notes for your reviewer:

Release note:

None

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 8, 2018
@qiwzhang qiwzhang requested review from costinm and lizan and removed request for sebastienvas May 8, 2018 21:37
@sebastienvas
Copy link
Copy Markdown
Contributor

/lgtm

@lizan
Copy link
Copy Markdown
Contributor

lizan commented May 8, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, sebastienvas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 42faac2 into istio:release-0.8 May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants