Skip to content

hardcode authority header for mixer temporarily#1740

Merged
kyessenov merged 2 commits into
istio:release-0.8from
lizan:mixer_authority
May 9, 2018
Merged

hardcode authority header for mixer temporarily#1740
kyessenov merged 2 commits into
istio:release-0.8from
lizan:mixer_authority

Conversation

@lizan
Copy link
Copy Markdown
Contributor

@lizan lizan commented May 9, 2018

What this PR does / why we need it:
Fixes #1737

Special notes for your reviewer:

Release note:

None

Signed-off-by: Lizan Zhou <zlizan@google.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from linsun and qiwzhang May 9, 2018 20:44
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 9, 2018
@lizan lizan requested a review from mandarjog May 9, 2018 20:45
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @qiwzhang the callback is called after prepareHeaders is called, which is the one guilty of setting the header.

Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lizan!

@mandarjog
Copy link
Copy Markdown
Contributor

Lizan


W0509 20:56:30.945]     ~~~~~~~~~~~~~~~~~^~~~~
W0509 20:56:30.945] bazel-out/k8-fastbuild/bin/external/envoy/include/envoy/http/_virtual_includes/header_map_interface/envoy/http/header_map.h:223:8: note: declared private here
W0509 20:56:30.945]   void value(const char*); // Do not allow auto conversion to std::string

Signed-off-by: Lizan Zhou <zlizan@google.com>
@kyessenov kyessenov merged commit 87907ac into istio:release-0.8 May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants