Skip to content

Merge changes from branch release-0.8#1770

Merged
istio-testing merged 6 commits into
istio:masterfrom
qiwzhang:merge_r08_1
May 23, 2018
Merged

Merge changes from branch release-0.8#1770
istio-testing merged 6 commits into
istio:masterfrom
qiwzhang:merge_r08_1

Conversation

@qiwzhang
Copy link
Copy Markdown
Contributor

@qiwzhang qiwzhang commented May 22, 2018

What this PR does / why we need it:

There are a couple changes from release-0.8

Special notes for your reviewer:

Release note:

None

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented May 22, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 22, 2018
@qiwzhang qiwzhang requested review from hklai and lizan and removed request for rshriram May 22, 2018 23:46
@qiwzhang qiwzhang added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 22, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented May 22, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

JimmyCYJ
JimmyCYJ approved these changes May 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented May 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimmyCYJ, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 6589f07 into istio:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizan lizan Awaiting requested review from lizan

@hklai hklai Awaiting requested review from hklai

1 more reviewer

@JimmyCYJ JimmyCYJ JimmyCYJ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JimmyCYJ JimmyCYJ

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiwzhang @googlebot @istio-testing @JimmyCYJ