Skip to content

Add forwarded_attributes to per route config#1776

Merged
istio-testing merged 8 commits into
istio:masterfrom
kyessenov:fine_grained_config
May 24, 2018
Merged

Add forwarded_attributes to per route config#1776
istio-testing merged 8 commits into
istio:masterfrom
kyessenov:fine_grained_config

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

Implements the API change istio/api#500

qiwzhang and others added 7 commits May 23, 2018 16:09
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing istio-testing requested review from linsun and qiwzhang May 23, 2018 23:12
@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 23, 2018
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Copy Markdown
Contributor Author

PTAL. This is a repeat of the old PR against master.

@kyessenov kyessenov added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 23, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kyessenov kyessenov removed the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 23, 2018
@qiwzhang
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 821d855 into istio:master May 24, 2018
@kyessenov kyessenov deleted the fine_grained_config branch May 24, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants