release 1.1: Update envoy to enable path normalization#2166
release 1.1: Update envoy to enable path normalization#2166duderino merged 3 commits intoistio:release-1.1from
Conversation
istio-testing
added
the
needs-rebase
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
envoy commit date: 04/10/2019 bazel version: 0.22.0 Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
istio-testing
removed
the
needs-rebase
lambdai
changed the title
| ) | ||
|
|
||
| # envoy commit date 04/10/2019 | ||
| # bazel version: 0.22.0 |
There was a problem hiding this comment.
It might be another pain if we forgot to update the comment... We will see.
| #) | ||
|
|
||
| load("@envoy//bazel:api_repositories.bzl", "envoy_api_dependencies") | ||
| envoy_api_dependencies() |
There was a problem hiding this comment.
Envoy is splitting /api to external repository. It's WIP and I am seeing error when I introduce envoy using local_repository.
With this fix, proxy build works perfectly no matter we introduce envoy by http or by local_repository.
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
| #local_repository( | ||
| # name = "envoy", | ||
| # path = LOCAL_ENVOY_PROJECT | ||
| #) |
There was a problem hiding this comment.
did stuff for building against a local envoy slip in here? I think it's fine to keep it here commented out, but if you do, please add a few comments describing what it's for
There was a problem hiding this comment.
Leave here because I probably pasted these lines 10 times in the last 2 weeks... I haven't figure out if we can use bazel arg to switch between local or http_archive
Let me add the comment.
lambdai
left a comment
lambdai
left a comment
There was a problem hiding this comment.
Will add the comment to local_repository
| #) | ||
|
|
||
| load("@envoy//bazel:api_repositories.bzl", "envoy_api_dependencies") | ||
| envoy_api_dependencies() |
There was a problem hiding this comment.
Envoy is splitting /api to external repository. It's WIP and I am seeing error when I introduce envoy using local_repository.
With this fix, proxy build works perfectly no matter we introduce envoy by http or by local_repository.
| #local_repository( | ||
| # name = "envoy", | ||
| # path = LOCAL_ENVOY_PROJECT | ||
| #) |
There was a problem hiding this comment.
Leave here because I probably pasted these lines 10 times in the last 2 weeks... I haven't figure out if we can use bazel arg to switch between local or http_archive
Let me add the comment.
| ) | ||
|
|
||
| # envoy commit date 04/10/2019 | ||
| # bazel version: 0.22.0 |
There was a problem hiding this comment.
It might be another pain if we forgot to update the comment... We will see.
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
/lgtm will merge once tests pass |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duderino, silentdai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
On top of #2158
And introduce the path normalization.
Q: How to build or test the path normalization?
A: Any make/bazel command should pickup the compilation option automatically. See .bazelrc